Skip to content

feat: Add Version selector dropdown #16746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Aug 18, 2025
Merged

feat: Add Version selector dropdown #16746

merged 18 commits into from
Aug 18, 2025

Conversation

Ajay-singh1
Copy link
Member

Description

This PR adds a version selector drop down for Istio documentation which allows user to navigate to older docs.

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

@Ajay-singh1 Ajay-singh1 requested a review from a team as a code owner August 3, 2025 06:43
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 3, 2025
@Ajay-singh1
Copy link
Member Author

@craigbox After this PR is merged should I go on and regenerate the archive docs from v1.25-v1.22 with the banner.

@craigbox
Copy link
Contributor

craigbox commented Aug 4, 2025

Quick thoughts from https://deploy-preview-16746--preliminary-istio.netlify.app/:

  • this should only appear on Docs pages
  • needs styling like the rest of the heading
  • I think we settled on "latest" (preliminary), "stable" (current version) and n-5 releases
  • "Try Istio" should remain top-right, so we will have to put this to the left of that
  • need a responsive version of it
Screenshot 2025-08-04 at 4 10 31 PM

@Ajay-singh1
Copy link
Member Author

Took note of the suggestion, working on it.

@Ajay-singh1 Ajay-singh1 added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Aug 4, 2025
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 5, 2025
@Ajay-singh1 Ajay-singh1 removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Aug 5, 2025
@Ajay-singh1 Ajay-singh1 requested a review from craigbox August 5, 2025 09:56
@Ajay-singh1
Copy link
Member Author

Good to Go!

@Ajay-singh1 Ajay-singh1 added the do-not-merge Block automatic merging of a PR. label Aug 6, 2025
@Ajay-singh1 @craigbox
Fix : Mobile View
2897ac7 
Co-authored-by: Craig Box <[email protected]>
@Ajay-singh1 @craigbox
More Styling
1df22ba 
Co-authored-by: Craig Box <[email protected]>
@Ajay-singh1 @craigbox
Fix: Mobile
414caf8 
Co-authored-by: Craig Box <[email protected]>
@Ajay-singh1 Ajay-singh1 added cherrypick/release-1.26 Set this label on a PR to auto-merge it to the release-1.26 branch and removed do-not-merge Block automatic merging of a PR. labels Aug 8, 2025
craigbox
craigbox reviewed Aug 11, 2025
View reviewed changes
Ajay-singh1 and others added 2 commits August 11, 2025 13:29
@istio-testing istio-testing removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 11, 2025
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 11, 2025
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 11, 2025
@Ajay-singh1
Copy link
Member Author

Thanks a lot @craigbox for the review really helped a lot.I have addressed all your comments.

@Ajay-singh1 Ajay-singh1 added cherrypick/release-1.27 Set this label on a PR to auto-merge it to the release-1.27 branch and removed cherrypick/release-1.26 Set this label on a PR to auto-merge it to the release-1.26 branch labels Aug 12, 2025
@Ajay-singh1 Ajay-singh1 requested a review from craigbox August 13, 2025 13:57
@Ajay-singh1
Copy link
Member Author

Ping: @craigbox

craigbox
craigbox approved these changes Aug 18, 2025
View reviewed changes
@craigbox craigbox added the do-not-merge/hold Block automatic merging of a PR. label Aug 18, 2025
craigbox
craigbox reviewed Aug 18, 2025
View reviewed changes
@Ajay-singh1
Copy link
Member Author

Done!

@Ajay-singh1 Ajay-singh1 removed the do-not-merge/hold Block automatic merging of a PR. label Aug 18, 2025
@istio-testing istio-testing merged commit 083b23b into istio:master Aug 18, 2025
6 checks passed
@istio-testing istio-testing mentioned this pull request Aug 18, 2025
Merged
@istio-testing
Copy link
Contributor

In response to a cherrypick label: new pull request created: #16787

@Ajay-singh1 Ajay-singh1 deleted the archive-docs branch August 19, 2025 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigbox craigbox craigbox approved these changes

Assignees
No one assigned
Labels
cherrypick/release-1.27 Set this label on a PR to auto-merge it to the release-1.27 branch size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ajay-singh1 @craigbox @istio-testing